Skip to content

[Workers] Mention Flagship in automatic provisioning docs#31990

Merged
irvinebroque merged 5 commits into
productionfrom
codex/workers-flagship-auto-provisioning
Jul 15, 2026
Merged

[Workers] Mention Flagship in automatic provisioning docs#31990
irvinebroque merged 5 commits into
productionfrom
codex/workers-flagship-auto-provisioning

Conversation

@ericclemmons

@ericclemmons ericclemmons commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

tl;dr – Add Flagship to Wrangler's automatic provisioning docs.

Wrangler supports automatic provisioning for Flagship bindings through cloudflare/workers-sdk#14640.

The automatic provisioning section now lists Flagship alongside KV, R2, and D1. A changelog entry announces the support and shows how to configure a Flagship binding without an app_id.


References: cloudflare/workers-sdk#14640

Documentation checklist

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/product-owners
/src/content/docs/workers/wrangler/ @cloudflare/wrangler, @irvinebroque, @cloudflare/product-owners, @MattieTK, @vy-ton

@ericclemmons ericclemmons marked this pull request as ready for review July 10, 2026 21:36
@ericclemmons ericclemmons requested review from a team, MattieTK and vy-ton as code owners July 10, 2026 21:36
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 2 warnings found in commit ec1c7b3.

Fix in your agent
Fix the following review findings in PR #31990 (https://github.com/cloudflare/cloudflare-docs/pull/31990).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.

---

## Code Review

### Warnings (1)

#### CR-085e117d1a1a · Incorrect product capability claim
- **File:** `src/content/docs/workers/wrangler/configuration.mdx` line 107
- **Issue:** The added line claims automatic provisioning works for Flagship bindings, but the [automatic provisioning changelog](src/content/changelog/workers/2025-10-24-automatic-resource-provisioning.mdx) explicitly limits the feature to KV, R2, and D1. The Flagship binding docs also require a pre-existing `app_id` resource identifier, which conflicts with automatic provisioning's model of omitting resource IDs.
- **Fix:** Remove "and Flagship" unless there is a supporting source confirming Flagship automatic provisioning is supported, and update the related changelog in the same PR.

---

## Style Guide Review

### Warnings (1)

#### SG-dd67ece9980c · WranglerConfig requires TOML input
- **File:** `src/content/changelog/workers/2026-07-09-flagship-automatic-provisioning.mdx` line 16
- **Issue:** `<WranglerConfig>` wraps a ` ```jsonc ` block; the component is designed to accept TOML and auto-generate JSONC.
- **Fix:** Change the inner fence to ` ```toml ` and write the Wrangler configuration in TOML.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
workers/wrangler/configuration.mdx line 107 Incorrect product capability claim — The added line claims automatic provisioning works for Flagship bindings, but the automatic provisioning changelog explicitly limits the feature to KV, R2, and D1. The Flagship binding docs also require a pre-existing app_id resource identifier, which conflicts with automatic provisioning's model of omitting resource IDs. Fix: Remove "and Flagship" unless there is a supporting source confirming Flagship automatic provisioning is supported, and update the related changelog in the same PR.

Conventions

No convention issues found.

Style Guide Review

Warnings (1)
File Issue
changelog/workers/2026-07-09-flagship-automatic-provisioning.mdx line 16 WranglerConfig requires TOML input<WranglerConfig> wraps a ```jsonc block; the component is designed to accept TOML and auto-generate JSONC. Fix: Change the inner fence to ```toml and write the Wrangler configuration in TOML.
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.

@irvinebroque irvinebroque enabled auto-merge (squash) July 11, 2026 16:14
@github-actions

Copy link
Copy Markdown
Contributor

@irvinebroque irvinebroque merged commit 30a43d3 into production Jul 15, 2026
15 checks passed
@irvinebroque irvinebroque deleted the codex/workers-flagship-auto-provisioning branch July 15, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants